Remove tab container from the schema page

[Anish9901]

Fixes #4056

Screenshot

Checklist

• My pull request has a descriptive title (not a vague title like Update index.md).
• My pull request targets the develop branch of the repository
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no
  visible errors.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[kgodey]

@Anish9901 don't close this yet, we might want to merge it, I was going to talk to @ghislaineguerin

[Anish9901]

Oh, alright @kgodey, I thought we weren't doing it.

[zackkrida]

I'm just going to draft this until a decision is made on how to proceed.

[seancolsen]

I think it makes sense to keep this as a draft for now. But I went ahead and took a look anyway.

Your changes looks great, @Anish9901. I did push d538603 to make the routing code follow the patterns used in other files, but I'm not 100% sure that's even necessary in this case. I just wanted to err on the safe side.

The effect of this PR is exactly what I had in mind when I originally opened this issue.

The concern that @ghislaineguerin raised on our call (discussion on this topic began at ~5:40) was that by making this change we'd lose the functionality to filter tables and explorations.

Personally, I don't think we need that functionality. I think simplicity is better in this case. But if we wanted to keep the filter bar, we could stick it below. It just gets a little tricky when filtering explorations because there is less space. So there is potentially some design work or improvisation to take into account if we go that direction.

[Anish9901]

The concern that @ghislaineguerin raised on our call (discussion on this topic began at ~5:40) was that by making this change we'd lose the functionality to filter tables and explorations.

Thanks @seancolsen, That makes sense, I got a lot of insights from that call.

[zackkrida]

We're going to move forward with this change after beta, as there are some additional necessary changes that may take time.

[seancolsen]

Regarding the comments @pavish made during today's meeting:

• It looks like SchemaExplorations.svelte and SchemaTables.svelte are now dead code that can be removed. @Anish9901 can you delete those files?

• As for any bugs in functionality. I think we're good here. I've testing when deleting tables and explorations. Redirection works as expected.

I'd like to merge this after the dead code is deleted. Is that okay with you, @pavish?