Image[] (again) #482
Merged
Image[] (again) #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've closed #378 in favour of this one. |
…ht tags to <img>.
…d in the PyPy rework to come
|
in its current form, this now depends on #480 |
| contents = stream.read() | ||
| stream.close() | ||
| with warnings.catch_warnings(): | ||
| warnings.simplefilter("ignore") |
There was a problem hiding this comment.
What warnings are we ignoring here? Are they important?
There was a problem hiding this comment.
Not really. During the conversion of floating point to byte components (which are necessary for the png encoding), PIL outputs a warning that precision might be lost. Since this code only handles the display for the frontend, it doesn't matter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of #378 to the Mathics branch.
It works perfectly in the classic Mathics web interface.
Combined with #480 and a small change, this will also work in Jupyter kernels.