Merge pull request #752 from mathuo/739-sonar-code-cleanup

chore: sonar
mathuo · Nov 3, 2024 · 7ebbd43 · 7ebbd43
2 parents 3f5c974 + d8ae04e
commit 7ebbd43
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/packages/dockview-core/src/dockview/dockviewComponent.ts b/packages/dockview-core/src/dockview/dockviewComponent.ts
@@ -592,12 +592,9 @@ export class DockviewComponent
             }
         );
 
-        let windowExplicitlyClosed = false;
-
         const popoutWindowDisposable = new CompositeDisposable(
             _window,
             _window.onDidClose(() => {
-                windowExplicitlyClosed = true;
                 popoutWindowDisposable.dispose();
             })
         );

diff --git a/packages/dockview-core/src/dockview/types.ts b/packages/dockview-core/src/dockview/types.ts
@@ -2,7 +2,7 @@ import { DockviewPanelApi } from '../api/dockviewPanelApi';
 import { PanelInitParameters, IPanel } from '../panel/types';
 import { DockviewApi } from '../api/component.api';
 import { Optional } from '../types';
-import { DockviewGroupPanel, IDockviewGroupPanel } from './dockviewGroupPanel';
+import { IDockviewGroupPanel } from './dockviewGroupPanel';
 import { DockviewPanelRenderer } from '../overlay/overlayRenderContainer';
 
 export interface HeaderPartInitParameters {

diff --git a/packages/dockview-core/src/splitview/splitview.ts b/packages/dockview-core/src/splitview/splitview.ts
@@ -101,7 +101,7 @@ export class Splitview {
     private readonly viewContainer: HTMLElement;
     private readonly sashContainer: HTMLElement;
     private readonly viewItems: ViewItem[] = [];
-    private sashes: ISashItem[] = [];
+    private readonly sashes: ISashItem[] = [];
     private _orientation: Orientation;
     private _size = 0;
     private _orthogonalSize = 0;