feat(room): Add fn Room::own_membership_details #4529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poljar
approved these changes
Jan 14, 2025
| /// current user's [`RoomMember`](RoomMember) info and the member info | ||
| /// of the sender of that member event. | ||
| /// - If the current user is not present, an error. | ||
| pub async fn own_membership_details(&self) -> Result<(RoomMember, Option<RoomMember>)> { |
There was a problem hiding this comment.
Can we get a simple smoke test for this method, I know it's a pretty simple method but it would still be nice to test its basic functionality.
There was a problem hiding this comment.
Added a few tests and force pushed. Thanks for the reminder, that uncovered a subtle bug!
This will retrieve the room member info of both the current user and the info for the sender of the current user's room member event.
Also add `membership_change_reason` field to `ffi::RoomMember`.
jmartinesp
force-pushed
the
feat/room-own-membership-details
branch
from
15f8457 to
c0f7ff0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4529 +/- ##
==========================================
+ Coverage 85.43% 85.45% +0.02%
==========================================
Files 285 285
Lines 32101 32112 +11
==========================================
+ Hits 27426 27442 +16
+ Misses 4675 4670 -5 ☔ View full report in Codecov by Sentry. |
poljar
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will retrieve the room member info of both the current user and the info for the sender of the current user's room member event and make it accessible in the FFI layer.
This is needed for
RoomPreviewto display messages such as 'you were banned from this room by Foo'.Signed-off-by: