Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: rename snapshots not to contain : #4539

Merged
merged 1 commit into from
Jan 16, 2025
Merged

test: rename snapshots not to contain : #4539

merged 1 commit into from
Jan 16, 2025

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Jan 16, 2025

Windows doesn't allow you to have : in its filenames

Windows doens't allow you to have `:` in its filenames
@richvdh richvdh requested a review from a team as a code owner January 16, 2025 10:50
@richvdh richvdh requested review from andybalaam and removed request for a team January 16, 2025 10:50
@richvdh richvdh enabled auto-merge (rebase) January 16, 2025 11:10
@richvdh richvdh merged commit 3dd81fb into main Jan 16, 2025
39 checks passed
@richvdh richvdh deleted the rav/rename_snapshots branch January 16, 2025 11:11
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.42%. Comparing base (6a0333e) to head (9fb393c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4539   +/-   ##
=======================================
  Coverage   85.42%   85.42%           
=======================================
  Files         285      285           
  Lines       32120    32120           
=======================================
+ Hits        27437    27438    +1     
+ Misses       4683     4682    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants