Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: simplify examples for KeyQueryResponseTemplate #4541

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Jan 16, 2025

Generating keys from slices rather than base64 is easier.

Also, s/builder/template/.

Generating keys from slices rather than base64 is easier.

Also, s/builder/template/.
@richvdh richvdh requested a review from a team as a code owner January 16, 2025 11:32
@richvdh richvdh requested review from jmartinesp and removed request for a team January 16, 2025 11:32
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.41%. Comparing base (c24770a) to head (c2d2e11).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4541      +/-   ##
==========================================
+ Coverage   85.40%   85.41%   +0.01%     
==========================================
  Files         285      285              
  Lines       32213    32213              
==========================================
+ Hits        27511    27516       +5     
+ Misses       4702     4697       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richvdh richvdh merged commit f231c74 into main Jan 16, 2025
40 checks passed
@richvdh richvdh deleted the rav/clarify_template_docs branch January 16, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants