Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ffi): silence useless logs coming out of the ffi crate #4542

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

stefanceriu
Copy link
Member

Setting the default log level to debug results in logs like:

log: log_event
log: latest_event
log: log_event
log: log_event
log: room_info
log: latest_event
log: log_event
log: room_info

Presumably they're coming out of the custom tracing configuration and we definitely don't need them

Setting the default log level to `debug` results in logs like:

```
log: log_event
log: latest_event
log: log_event
log: log_event
log: room_info
log: latest_event
log: log_event
log: room_info
```

Presumably they're coming out of the custom tracing configuration and we definitely don't need them.
@stefanceriu stefanceriu requested a review from a team as a code owner January 16, 2025 12:34
@stefanceriu stefanceriu requested review from bnjbvr and removed request for a team January 16, 2025 12:34
@poljar poljar requested review from poljar and removed request for bnjbvr January 16, 2025 12:36
Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, it's telling you which function is called or something like that.

Makes sense.

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.42%. Comparing base (c969f90) to head (803d447).
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4542      +/-   ##
==========================================
- Coverage   85.43%   85.42%   -0.01%     
==========================================
  Files         285      285              
  Lines       32112    32112              
==========================================
- Hits        27435    27433       -2     
- Misses       4677     4679       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu stefanceriu merged commit 2cb6ee8 into main Jan 16, 2025
40 checks passed
@stefanceriu stefanceriu deleted the stefan/verboseLogs branch January 16, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants