Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Send-less BoxFuture for HttpClient Service impl on wasm #4544

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

jplatte
Copy link
Collaborator

@jplatte jplatte commented Jan 16, 2025

The dependencies required for the experimental-oidc feature don't currently compile on WASM, but once they do this is another thing inside this repo that's required for the feature to work on WASM.

@jplatte jplatte requested a review from a team as a code owner January 16, 2025 21:04
@jplatte jplatte requested review from poljar and removed request for a team January 16, 2025 21:04
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.40%. Comparing base (2bd8c56) to head (1cfa087).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4544   +/-   ##
=======================================
  Coverage   85.40%   85.40%           
=======================================
  Files         285      285           
  Lines       32213    32213           
=======================================
+ Hits        27511    27512    +1     
+ Misses       4702     4701    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poljar poljar merged commit f7db52e into main Jan 17, 2025
40 checks passed
@poljar poljar deleted the jplatte/oidc-wasm-future-boxing branch January 17, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants