Simplify some tests with the assert_next_with_timeout macro #4598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartinesp
reviewed
Jan 31, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4598 +/- ##
==========================================
+ Coverage 85.71% 85.72% +0.01%
==========================================
Files 291 291
Lines 33290 33290
==========================================
+ Hits 28534 28539 +5
+ Misses 4756 4751 -5 ☔ View full report in Codecov by Sentry. |
poljar
force-pushed
the
poljar/simplify-tests-assert-next
branch
from
4187db4 to
e9c730d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to figure out why #4596 fails, I noticed that some tests reimplement the
assert_next_with_timeoutmacro using a function.While I'm doing this I expanded the macro to make the timeout parameter optional and added some doc examples to the macro.
Additionally I noticed that one of our examples seems to contain a bug because of a misplaced
#.A review commit by commit makes the most sense.