Send M_TOKEN_INCORRECT as per MSC4183

matrix-org · Aug 29, 2024 · 8e5447a · 8e5447a
1 parent a37d60b
commit 8e5447a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/sydent/http/servlets/emailservlet.py b/sydent/http/servlets/emailservlet.py
@@ -220,10 +220,11 @@ def do_validate_request(self, request: Request) -> JsonDict:
                 "error": "The token doesn't match",
             }
         except IncorrectSessionTokenException:
+            request.setResponseCode(400)
             return {
                 "success": False,
-                "errcode": "M_NO_VALID_SESSION",
-                "error": "No session could be found with this sid",
+                "errcode": "M_TOKEN_INCORRECT",
+                "error": "The token supplied is incorrect",
             }
 
     def render_OPTIONS(self, request: Request) -> bytes:

diff --git a/sydent/http/servlets/msisdnservlet.py b/sydent/http/servlets/msisdnservlet.py
@@ -251,11 +251,11 @@ def do_validate_request(self, request: Request) -> JsonDict:
                 "error": "The token doesn't match",
             }
         except IncorrectSessionTokenException:
-            request.setResponseCode(404)
+            request.setResponseCode(400)
             return {
                 "success": False,
-                "errcode": "M_NO_VALID_SESSION",
-                "error": "No session could be found with this sid",
+                "errcode": "M_TOKEN_INCORRECT",
+                "error": "The token supplied is incorrect",
             }
 
     def render_OPTIONS(self, request: Request) -> bytes: