Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: custom sms provider using config #562

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: custom sms provider using config #562

wants to merge 5 commits into from

Conversation

AzikDeveloper
Copy link

Pull Request Checklist

  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fix a bug that prevented receiving messages from other servers." instead of "Move X method from EventStore to EventWorkerStore.".
    • Include 'Contributed by Your Name.' or 'Contributed by @your-github-username.' — unless you would prefer not to be credited in the changelog.
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
  • Pull request includes a sign off

@AzikDeveloper AzikDeveloper requested a review from a team as a code owner May 1, 2023 14:56
clokep
clokep suggested changes May 1, 2023
View reviewed changes
Copy link
Member

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally this will need a changelog file / sign-off as the PR template says.

sydent/config/sms.py Outdated Show resolved Hide resolved
sydent/config/sms.py
@@ -33,6 +35,16 @@ def parse_config(self, cfg: "ConfigParser") -> bool:
self.api_username = cfg.get("sms", "username").encode("UTF-8")
self.api_password = cfg.get("sms", "password").encode("UTF-8")

self.provider_class = sydent.sms.openmarket.OpenMarketSMS
try:
sms_provider = cfg.get("sms", "provider")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add documentation for this configuration option.

@clokep
Copy link
Member

clokep commented Sep 5, 2023

@AzikDeveloper Do you have interest in finishing this off? See the comments above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clokep clokep clokep requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AzikDeveloper @clokep @akhushnazarov