fix: remove short name param from network config

matter-labs · Dec 20, 2023 · 4313fe8 · 4313fe8
1 parent 5bc2dec
commit 4313fe8
Show file tree

Hide file tree

Showing 6 changed files with 3 additions and 31 deletions.
diff --git a/data/networks.ts b/data/networks.ts
@@ -28,7 +28,6 @@ export type ZkSyncNetwork = {
   id: number;
   key: string;
   name: string;
-  shortName: string;
   rpcUrl: string;
   hidden?: boolean; // If set to true, the network will not be shown in the network selector
   l1Network?: L1Network;
@@ -48,7 +47,6 @@ export const inMemoryNode: ZkSyncNetwork = {
   id: 260,
   key: "in-memory-node",
   name: "In-memory node",
-  shortName: "In-memory local node",
   rpcUrl: "http://localhost:8011",
 };
 
@@ -57,7 +55,6 @@ export const dockerizedNode: ZkSyncNetwork = {
   id: 270,
   key: "dockerized-node",
   name: "Dockerized local node",
-  shortName: "Dockerized node",
   rpcUrl: "http://localhost:3050",
   l1Network: {
     id: 9,
@@ -76,7 +73,6 @@ export const zkSyncNetworks: ZkSyncNetwork[] = [
     id: 324,
     key: "mainnet",
     name: "zkSync",
-    shortName: "zkSync",
     rpcUrl: "https://mainnet.era.zksync.io",
     blockExplorerUrl: "https://explorer.zksync.io",
     blockExplorerApi: "https://block-explorer-api.mainnet.zksync.io",
@@ -89,7 +85,6 @@ export const zkSyncNetworks: ZkSyncNetwork[] = [
     id: 300,
     key: "sepolia",
     name: "zkSync Sepolia Testnet",
-    shortName: "zkSync Sepolia",
     rpcUrl: "https://sepolia.era.zksync.dev",
     blockExplorerUrl: "https://sepolia.explorer.zksync.io",
     blockExplorerApi: "https://block-explorer-api.sepolia.zksync.dev",
@@ -102,7 +97,6 @@ export const zkSyncNetworks: ZkSyncNetwork[] = [
     id: 280,
     key: "goerli",
     name: "zkSync Goerli Testnet",
-    shortName: "zkSync Goerli",
     rpcUrl: "https://testnet.era.zksync.dev",
     blockExplorerUrl: "https://goerli.explorer.zksync.io",
     blockExplorerApi: "https://block-explorer-api.testnets.zksync.dev",
@@ -115,7 +109,6 @@ export const zkSyncNetworks: ZkSyncNetwork[] = [
     id: 270,
     key: "stage",
     name: "zkSync Stage",
-    shortName: "zkSync Stage",
     rpcUrl: "https://z2-dev-api.zksync.dev",
     blockExplorerUrl: "https://goerli-beta.staging-scan-v2.zksync.dev",
     blockExplorerApi: "https://block-explorer-api.stage.zksync.dev",

diff --git a/hyperchains/README.md b/hyperchains/README.md
@@ -60,7 +60,6 @@ Array<{
     id: number; // L2 Network ID
     rpcUrl: string; // L2 RPC URL
     name: string;
-    shortName: string;
     blockExplorerUrl?: string; // L2 Block Explorer URL
     hidden?: boolean; // Hidden in the network selector
     l1Network?: { // @wagmi `Chain` structure https://wagmi.sh/core/chains#build-your-own

diff --git a/hyperchains/example.config.json b/hyperchains/example.config.json
@@ -4,7 +4,6 @@
       "id": 1234,
       "key": "my-hyperchain",
       "name": "My new hyperchain",
-      "shortName": "My hyperchain",
       "rpcUrl": "http://127.0.0.1:3050",
       "l1Network": {
         "id": 9,

diff --git a/pages/index.vue b/pages/index.vue
@@ -186,7 +186,7 @@ const depositMethods = computed(() => {
   methods.push({
     props: {
       label: "View your address",
-      description: `Receive tokens from another ${eraNetwork.value.shortName} account`,
+      description: `Receive tokens from another ${eraNetwork.value.name} account`,
       as: "RouterLink",
       to: {
         name: "receive",

diff --git a/scripts/hyperchains/configure.ts b/scripts/hyperchains/configure.ts
@@ -44,7 +44,6 @@ const createNetworkFromEnv = (envPath: string): Network => {
     id: Number(env.CHAIN_ETH_ZKSYNC_NETWORK_ID),
     key: baseName,
     name: env.CHAIN_ETH_ZKSYNC_NETWORK,
-    shortName: env.CHAIN_ETH_ZKSYNC_NETWORK,
     rpcUrl: env.API_WEB3_JSON_RPC_HTTP_URL,
     l1Network: {
       id: Number(env.ETH_CLIENT_CHAIN_ID),
@@ -102,21 +101,14 @@ const promptNetworkEnv = async () => {
   return createNetworkFromEnv(pathJoin(envsDirectory, `${selectedEnv}.env`));
 };
 const promptNetworkInfo = async (network: Network) => {
-  const { name, shortName, l1NetworkName }: { name: string; shortName: string; l1NetworkName: string } = await prompt([
+  const { name, l1NetworkName }: { name: string; l1NetworkName: string } = await prompt([
     {
       message: "Displayed network name",
       name: "name",
       type: "input",
       initial: network.name,
       required: true,
     },
-    {
-      message: "Displayed network short name",
-      name: "shortName",
-      type: "input",
-      initial: network.shortName,
-      required: true,
-    },
     {
       message: "Displayed L1 network name",
       name: "l1NetworkName",
@@ -127,7 +119,6 @@ const promptNetworkInfo = async (network: Network) => {
   ]);
 
   network.name = name;
-  network.shortName = shortName;
   network.l1Network.name = l1NetworkName;
 };
 

diff --git a/scripts/hyperchains/create.ts b/scripts/hyperchains/create.ts
@@ -21,15 +21,6 @@ const promptHyperchainInfo = async (): Promise<Network> => {
       required: true,
     },
   ]);
-  const { shortName }: { shortName: string } = await prompt([
-    {
-      message: "Displayed hyperchain short name",
-      name: "shortName",
-      type: "input",
-      required: true,
-      initial: name,
-    },
-  ]);
   const {
     key,
     rpcUrl,
@@ -41,7 +32,7 @@ const promptHyperchainInfo = async (): Promise<Network> => {
       name: "key",
       type: "input",
       required: true,
-      initial: slugify(shortName, {
+      initial: slugify(name, {
         lower: true,
         replacement: "-",
         strict: true,
@@ -137,7 +128,6 @@ const promptHyperchainInfo = async (): Promise<Network> => {
   return {
     id,
     name,
-    shortName,
     key,
     rpcUrl,
     blockExplorerUrl,