Add custom sidecar containers pod extension #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mm-cloud-bot
added
the
release-note
gabrieljackson
force-pushed
the
custom-sidecars
branch
from
8bb4ea1 to
5a4fa0a
Compare
This new pod extension allows for additional containers to be added to the primary Mattermost app pod. In the future, this pod extension may be migrated to the init container style of sidecars that was recently introduced in k8s.
gabrieljackson
force-pushed
the
custom-sidecars
branch
from
5a4fa0a to
efdfdc8
Compare
gabrieljackson
added
2: Dev Review
nickmisasi
approved these changes
Jan 10, 2024
gabrieljackson
added
3: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new pod extension allows for additional containers to be injected into the Mattermost app pod.
In the future, this pod extension may be migrated to the init container style of sidecars that was recently introduced in k8s v1.28. https://kubernetes.io/blog/2023/08/25/native-sidecar-containers/
Fixes https://mattermost.atlassian.net/browse/CLD-6896 and mattermost/mattermost#16876