Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove vendor directory #374

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Remove vendor directory #374

merged 1 commit into from
Mar 25, 2024

Conversation

gabrieljackson
Copy link
Collaborator

@gabrieljackson gabrieljackson commented Mar 25, 2024 •
edited
Loading

This change removes the vendor directory in favor of pulling down dependencies as needed. The code-generator script has been moved from the vendor directory to scripts as a temporary solution until a newer process is implemented for generation.

Fixes https://mattermost.atlassian.net/browse/CLD-7371

None

@gabrieljackson
Remove vendor directory
2541b9c 
This change removes the `vendor` directory in favor of pulling
down dependencies as needed. The code-generator script has been
moved from the `vendor` directory to `scripts` as a temporary
solution until a newer process is implemented for generation.
@mm-cloud-bot mm-cloud-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 25, 2024
@gabrieljackson gabrieljackson added 2: Dev Review Requires review by a developer kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Mar 25, 2024
@gabrieljackson gabrieljackson marked this pull request as ready for review March 25, 2024 12:55
fmartingr
fmartingr approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@fmartingr fmartingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You can remove the first line of the .gitattributes file too.

nickmisasi
nickmisasi approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@nickmisasi nickmisasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vendor folder giving node_modules a run for its money. LGTM

@gabrieljackson gabrieljackson added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a developer labels Mar 25, 2024
@gabrieljackson gabrieljackson merged commit c96ae26 into master Mar 25, 2024
5 checks passed
@gabrieljackson gabrieljackson deleted the remove-vendor-dir branch March 25, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickmisasi nickmisasi nickmisasi approved these changes

@fmartingr fmartingr fmartingr approved these changes

Assignees
No one assigned
Labels
3: Reviews Complete All reviewers have approved the pull request kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gabrieljackson @fmartingr @nickmisasi @mm-cloud-bot