Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve external E2E test logic #377

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Conversation

gabrieljackson
Copy link
Collaborator

@gabrieljackson gabrieljackson commented Apr 8, 2024

This change does the following:

  • Converts individual external E2E tests to subtests. This now matches the standard E2E test flow and provides better test logging output.
  • Split Mattermost version upgrade test out from base test.
  • Improve reconciliation logging with more status output.
  • Improve reconciliation check with ObservedGeneration validation.
  • Update external E2E postgres container image to version 14.

Fixes https://mattermost.atlassian.net/browse/CLD-7478

Improve external E2E test logic

This change does the following:
 - Converts individual external E2E tests to subtests. This now
   matches the standard E2E test flow and provides better test
   logging output.
 - Split Mattermost version upgrade test out from base test.
 - Improve reconciliation logging with more status output.
 - Improve reconciliation check with ObservedGeneration validation.
 - Update external E2E postgres container image to version 14.
@mm-cloud-bot mm-cloud-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 8, 2024
@gabrieljackson gabrieljackson marked this pull request as ready for review April 9, 2024 13:22
Copy link
Contributor

@stafot stafot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabrieljackson gabrieljackson merged commit 4f460af into master Apr 16, 2024
5 checks passed
@gabrieljackson gabrieljackson deleted the external-test-cleanup branch April 16, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants