Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow setting a custom liveness probe timeout #385

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

swills
Copy link
Contributor

@swills swills commented Oct 29, 2024

Currently you can set some custom values for liveness probes but you can't set the timeout. I ran into an issue and needed to set it.

@mm-cloud-bot
Copy link

@swills: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

@gabrieljackson gabrieljackson added 2: Dev Review Requires review by a developer kind/bug Categorizes issue or PR as related to a bug. labels Oct 29, 2024
Copy link
Contributor

@nickmisasi nickmisasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @swills

Copy link
Collaborator

@gabrieljackson gabrieljackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@gabrieljackson gabrieljackson added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a developer labels Oct 31, 2024
@gabrieljackson gabrieljackson merged commit 4f59dc0 into mattermost:master Oct 31, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request do-not-merge/release-note-label-needed kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants