Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed code maintainer, co-maintainer from the README #545

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Removed code maintainer, co-maintainer from the README #545

wants to merge 2 commits into from
+0 −4

Conversation

Kshitij-Katiyar
Copy link
Contributor

@Kshitij-Katiyar Kshitij-Katiyar commented Jan 13, 2025 •
edited
Loading

Summary

Removed code maintainer, co-maintainer from the README

@Kshitij-Katiyar Kshitij-Katiyar self-assigned this Jan 13, 2025
wiggin77
wiggin77 requested changes Jan 13, 2025
View reviewed changes
Copy link
Member

@wiggin77 wiggin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the maintainers section, including co-maintainer.

@raghavaggarwal2308 raghavaggarwal2308 changed the title updated code owner/maintainer updated code owner/maintainer in README Jan 14, 2025
@Kshitij-Katiyar Kshitij-Katiyar changed the title updated code owner/maintainer in README Removed code owner/maintainer from the README Jan 15, 2025
@Kshitij-Katiyar Kshitij-Katiyar changed the title Removed code owner/maintainer from the README Removed code maintainer, co-maintainer from the README Jan 15, 2025
@Kshitij-Katiyar
Copy link
Contributor Author

Let's remove the maintainers section, including co-maintainer.

@wiggin77 Done

@Kshitij-Katiyar Kshitij-Katiyar added the 2: Dev Review Requires review by a core committer label Jan 15, 2025
hanzei
hanzei reviewed Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also remove https://github.com/mattermost/mattermost-plugin-gitlab/blob/master/CODEOWNERS?

@wiggin77
Copy link
Member

Should we also remove https://github.com/mattermost/mattermost-plugin-gitlab/blob/master/CODEOWNERS?

I don't think so, however I would like to have core committers there instead of just me.

@hanzei
Copy link
Collaborator

hanzei commented Jan 15, 2025

Should we also remove master/CODEOWNERS?

I don't think so, however I would like to have core committers there instead of just me.

Who is on your mind? Is @spirosoik still reviewing changes?

@spirosoik
Copy link
Member

Fine with it.

@wiggin77
Copy link
Member

Should we also remove master/CODEOWNERS?

I don't think so, however I would like to have core committers there instead of just me.

Who is on your mind? Is @spirosoik still reviewing changes?

I mean the Core Committers group listed in codeowners so that any core committer can approve and merge. Or we could create a specific group for plugins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanzei hanzei hanzei left review comments

@raghavaggarwal2308 raghavaggarwal2308 raghavaggarwal2308 approved these changes

@wiggin77 wiggin77 wiggin77 approved these changes

@spirosoik spirosoik spirosoik approved these changes

Assignees

@Kshitij-Katiyar Kshitij-Katiyar

Labels
2: Dev Review Requires review by a core committer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kshitij-Katiyar @wiggin77 @hanzei @spirosoik @raghavaggarwal2308