Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-595] Add feature to view shared calendars while creating an event #86

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[MM-595] Add feature to view shared calendars while creating an event #86

wants to merge 2 commits into from

Conversation

ayusht2810
Copy link

@ayusht2810 ayusht2810 commented Jul 17, 2024 •
edited
Loading

Summary

  • Added feature to view shared calendars while creating an event

Ticket Link

Fixes #59

How to test?

  • Run the command /gcal event create
  • User should be able to view and create events on the shared calendar

Note: - Merge PR mattermost/mattermost-plugin-mscalendar#379 before merging this PR and update version of mscalendar plugin in go.mod file

@ayusht2810 ayusht2810 self-assigned this Jul 17, 2024
@ayusht2810 ayusht2810 added the 2: Dev Review Requires review by a core committer label Jul 17, 2024
raghavaggarwal2308
raghavaggarwal2308 requested changes Jul 22, 2024
View reviewed changes
gcal/calendar.go Outdated Show resolved Hide resolved
webapp/src/components/calendar_selector.tsx Outdated Show resolved Hide resolved
go.mod
@@ -3,7 +3,7 @@ module github.com/mattermost/mattermost-plugin-google-calendar
go 1.21

require (
github.com/mattermost/mattermost-plugin-mscalendar v1.3.0
github.com/mattermost/mattermost-plugin-mscalendar v1.2.2-0.20240717132440-5de872875282
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have we updated this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was needed to link with the mscalendar changes for the API. We will update this once we merge the PR mattermost/mattermost-plugin-mscalendar#379

@ayusht2810 ayusht2810 added the Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) label Jul 22, 2024
@wiggin77 wiggin77 added 3: QA Review Requires review by a QA tester and removed 2: Dev Review Requires review by a core committer labels Aug 1, 2024
@wiggin77
Copy link
Member

wiggin77 commented Aug 1, 2024

@ayusht2810 which PR is this waiting for?

@raghavaggarwal2308
Copy link

@wiggin77 This PR is dependent on mattermost/mattermost-plugin-mscalendar#379. Once that PR is merged, we can test and merge this one.
But since there is an issue on the master branch of mscalendar plugin, I am think of not merging any new changes in that until we debug the issue. What are your opinions on this?

@wiggin77
Copy link
Member

wiggin77 commented Aug 5, 2024

@wiggin77 This PR is dependent on mattermost/mattermost-plugin-mscalendar#379. Once that PR is merged, we can test and merge this one.
But since there is an issue on the master branch of mscalendar plugin, I am think of not merging any new changes in that until we debug the issue. What are your opinions on this?

I agree. Let's not make significant changes until the blocker is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raghavaggarwal2308 raghavaggarwal2308 raghavaggarwal2308 approved these changes

@wiggin77 wiggin77 wiggin77 approved these changes

@AayushChaudhary0001 AayushChaudhary0001 Awaiting requested review from AayushChaudhary0001

Assignees

@ayusht2810 ayusht2810

Labels
3: QA Review Requires review by a QA tester Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to view calendars shared to user
3 participants
@ayusht2810 @wiggin77 @raghavaggarwal2308