Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-179]: Fixed the API testcase by adding the flag #192

Merged
merged 3 commits into from
May 8, 2024
Merged

Conversation

Kshitij-Katiyar
Copy link
Contributor

Summary

  1. Fixed the API test cases by adding the flag for the monkey patching to work properly. Reference: https://github.com/bouk/monkey?tab=readme-ov-file#notes

Issue: #179

@mickmister
Copy link
Contributor

@toninis Any ideas why CI doesn't run for this PR? Other PRs in this repo are having this same issue as well, both new and older PRs

@mickmister mickmister requested a review from hanzei May 8, 2024 16:02
@mickmister mickmister enabled auto-merge (squash) May 8, 2024 16:02
@mickmister mickmister merged commit b6b273e into master May 8, 2024
3 checks passed
@mickmister mickmister deleted the GH-179 branch May 8, 2024 16:12
raghavaggarwal2308 added a commit that referenced this pull request Nov 29, 2024
* [MM-64] Update plugin with respect to phase 1 upgrades

* Sync with playbooks: install-go-tools, gotestsum, and dynamic versions (#192)

* Revert "Update main.go (#154)"

This reverts commit be4a281.

* Revert "[MM-33506] Use embed package to include plugin manifest (#145)"

This reverts commit ca9ee3c.

* Revert "Don't generate manifest.ts (#127)"

This reverts commit 18d30b5.

* install-go-tools target, adopt gotestsum

* bring back make apply + automatic versioning

* Update build/manifest/main.go

Co-authored-by: Michael Kochell <[email protected]>

* suppress git describe error when no tags match

* make version/release notes opt-in

* fix whitespace in Makefile

* document version management options

---------

Co-authored-by: Michael Kochell <[email protected]>

* Fetch plugin logs from server (#193)

Co-authored-by: Jesse Hallam <[email protected]>

* [MM-64]: fixed lint issues

* [MM-64]: fixed the lint for the backend

* [MM-64]: updated the type of views in global state

* [MM-64]: fixed linting issues

* [MM-64] Update condition for refetching

* [MM-57194]: mark confidential settings as secret (#201)

* force CI

* Fix lint error

---------

Co-authored-by: Jesse Hallam <[email protected]>
Co-authored-by: Michael Kochell <[email protected]>
Co-authored-by: Ben Schumacher <[email protected]>
Co-authored-by: kshitij katiyar <[email protected]>
Co-authored-by: Raghav Aggarwal <[email protected]>
Co-authored-by: kshitij katiyar <[email protected]>
Co-authored-by: wiggin77 <[email protected]>
Co-authored-by: Antonis Stamatiou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants