GetChatInfo implementation #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tulir
reviewed
Jan 15, 2024
imessage/bluebubbles/api.go
Outdated
| @@ -261,7 +261,7 @@ func (bb *blueBubbles) GetMessage(guid string) (resp *imessage.Message, err erro | |||
| return nil, ErrNotImplemented | |||
| } | |||
|
|
|||
| func (bb *blueBubbles) apiUrl(path string) string { | |||
| func (bb *blueBubbles) apiUrl(path string, queryParams *map[string]string) string { | |||
There was a problem hiding this comment.
This doesn't need to be a pointer, empty map has the same effect and maps can also be nil
There was a problem hiding this comment.
i'm so used to Rust haha thank you!
imessage/bluebubbles/interface.go
Outdated
| GroupId string `json:"groupId"` | ||
| GUID string `json:"guid"` | ||
| ChatIdentifier string `json:"chatIdentifier"` | ||
| GroupId string `json:"groupId,omitempty"` |
There was a problem hiding this comment.
This field was already there, but as a side note, ID should be uppercase https://go.dev/wiki/CodeReviewComments#initialisms
tulir
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding GetChatInfo implementation.
The bridge starts up successfully, but I haven't checked to make sure the data that is in the struct is exactly what we expect.