Update api.go to implement websocket retry #187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rollingonchrome
requested review from
cnuss and
trek-boldly-go
as code owners
cnuss
requested changes
Feb 16, 2024
| @@ -122,7 +122,13 @@ func (bb *blueBubbles) PollForWebsocketMessages() { | |||
| if websocket.IsUnexpectedCloseError(err, websocket.CloseGoingAway, websocket.CloseAbnormalClosure) { | |||
| bb.log.Error().Err(err).Msg("Error reading message from BlueBubbles websocket") | |||
| } | |||
| bb.log.Info().Msg("Attempting to reconnect to BlueBubbles websocket...") | |||
| err = bb.retryConnect() | |||
There was a problem hiding this comment.
I'm not seeing the retryConnect function anywhere, do you have to make one?
- I think you should probably do everything in lines 87-97 in
retryConnect, the initial handshake is important - also would be a good idea to bake in a 5-10 sec sleep and Max retries. if the BB URL changes, which it does often, you don't want this looping aggressively forever
There was a problem hiding this comment.
@cnuss we are actually talking about this in the mautrix-imessage channel already. ChatGPT just hallucinated on @rollingonchrome
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per my exchange with Donovon, I worked with ChatGPT to attempt to implement a websocket retry with exponential backoff.