-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gimbal protocol v2 plugin #1825
Open
Mark-Beaty
wants to merge
6
commits into
mavlink:ros2
Choose a base branch
from
adinkra-labs:gimbal-protocol-v2-plugin
base: ros2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
614fd29
Added gimbal_control plugin
Mark-Beaty cb6e331
Final touches
Mark-Beaty 43ff913
Corrected build errors and warnings
Mark-Beaty 953e0f6
Removed exception after testing behavior
Mark-Beaty 389117a
Code cleanup
Mark-Beaty c2ba709
Adding example service calls
Mark-Beaty File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,6 +34,28 @@ fake\_gps | |
Sends fake GPS from local position estimation source data (motion capture, vision) to FCU. | ||
|
||
|
||
gimbal\_control | ||
---- | ||
|
||
Adds support for Mavlink Gimbal Protocol v2. To publish to tf, set parameter | ||
tf_send=True. The implementation of this plugin has been tested with a | ||
Freefly Astro with the mapping payload as well as with Auterion Sim. The | ||
plugin was built following the specifications available at | ||
https://mavlink.io/en/services/gimbal_v2.html with some adaptation to better | ||
suit ROS2 and support tf publishing with child frame labels specified by the | ||
gimbal_device_id field of gimbal_attitude_msg. This should enable support for | ||
multiple gimbal devices on the target platform publishing to different leaves | ||
of the tf tree. The assumed frame for each gimbal device is base_link_frd. | ||
When taking control of the gimbal with the GimbalManagerConfigure, sysid_primary | ||
can be set to -2, and default gimbal_device_id is 154, though 0 can be used for all | ||
gimbal devices. After taking control of the gimbal, you can set RoI's or manually | ||
set the gimbal's orientation using the service calls provided. The topic publishers | ||
for gimbal control have not been successfully validated, though this is possibly due | ||
to the implimentation on the Freefly Astro or with Auterion's simulator. Feel | ||
free to reach out to [email protected] with any questions or feedback on | ||
this plugin! | ||
|
||
|
||
gps\_input | ||
----------- | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you haven't used
cog.py
to re-generate that file?