Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New definitions of displayed and vertical universal elements #117

Merged
merged 12 commits into from
Dec 13, 2024

Conversation

maxsnew
Copy link
Owner

@maxsnew maxsnew commented Dec 5, 2024

This is a big refactor of the displayed universal property stuff we have so far:

  1. Redefines displayed right adjoint so we don't need RightAdjoint' anymore.
  2. Defines the fiber category over an object, and vertical composition between morphisms in the fiber and displayed morphisms.
  3. Defines displayed universalElement using IsoOver, which corresponds more directly to the natural thing in eliminators for free categories
  4. Give a separate definition of vertical universal elements which uses Iso and vertical composition
  5. Changed to a simpler definition of cartesianLift

The code is still a bit of a mess and I think we should do some name changing, but wanted to push so @hejohns and I can discuss

@maxsnew maxsnew requested a review from hejohns December 5, 2024 17:51
@maxsnew maxsnew marked this pull request as ready for review December 9, 2024 15:34
@maxsnew
Copy link
Owner Author

maxsnew commented Dec 9, 2024

@hejohns this is ready

hejohns added a commit that referenced this pull request Dec 10, 2024
Copy link
Collaborator

@hejohns hejohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new definitions look good. Haven't tried using them yet.
Just had a question in the comments on this PR about why some seemingly automatically generated normalized proof terms are there, when they don't seem necessary.

Gluing/Conservativity.agda Show resolved Hide resolved
@maxsnew maxsnew merged commit b7a0fa5 into main Dec 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants