Feature/464 permission admin view slow #508
Conversation
There was a problem hiding this comment.
I was thinking of the following to make it possible to fetch the fields via the frontend (such that the form doesn't have to be saved to fetch them):
- make an endpoint on the admin (that requires admin authentication) that performs the request for a specific object_type_id to retrieve the
data_fields(e.g./admin/objecttypes/<id>). That way we don't have to expose the token to the frontend and we only need to pass theidto the frontend - in react, call this new endpoint for the currently selected objecttype and display the result
@annashamray what do you think about this?
danielmursa-dev
requested review from
stevenbal
and removed request for
alextreme
There was a problem hiding this comment.
One thing I've noticed now, but it's been implemented like this since the beginning:
The state of selected fields is not tracked:
If you change the objecttype in the dropdown and then change it back, the fields previous will not be selected, even if they are saved in the DB
Screencast from 28-01-25 16:32:04.webm
It's been like this probably forever, so could you please create an issue to fix it?
No need to fix it in this PR, but some cleanup would be nice
| object_type = ObjectTypeFactory.create() | ||
| url = reverse("admin:objecttype_versions", args=[object_type.pk]) | ||
|
|
||
| with self.assertRaises(requests_mock.exceptions.NoMockAddress): |
There was a problem hiding this comment.
This is an exception that won't happen outside of tests, you can specify exc=... to let requests_mock raise a specific exception for a URL:
from requests.exceptions import HTTPError
m.get(f"{object_type.url}/versions", exc=HTTPError)And I think in that case, the endpoint returns an empty list
| url = reverse("admin:objecttype_versions", args=[100]) | ||
| response = self.app.get(url, user=user) | ||
| self.assertEqual(response.status_code, 200) | ||
| self.assertEqual(len(response.json), 0) |
There was a problem hiding this comment.
let's verify that it is an empty list (and not an object or something else with len == 0)
| self.assertEqual(len(response.json), 0) | |
| self.assertEqual(response.json, []) |
| self.assertEqual(len(response.json), 1) | ||
|
|
||
| # object_type does not exist | ||
| url = reverse("admin:objecttype_versions", args=[100]) |
There was a problem hiding this comment.
Dependent on the amount of objecttypes created in other tests (or using --keepdb locally) this PK might be valid, so let's make sure it is unused
| url = reverse("admin:objecttype_versions", args=[100]) | |
| url = reverse("admin:objecttype_versions", args=[object_type.pk+1]) |
Fixes #464
An internal administration endpoint
admin/core/objecttype/<objecttype_id>/_versions/was created to retrieve all versions related to the objecttype.Then the FE part was modified, so that each time an objecttype is modifie/selectedd, it call a new request to the endpoint.