Adding id, name, and value to form fields. #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently form fields are missing id and name. On the previous line you can see the label is using the node.id, so using this in the input to match.
Similar to id and name, value wasn't present on the inputs. On pages where submits send the user back to the form, this would mean that all values would be cleared out after form submission rather than being preserved in the form.
coryveilleux
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently form fields are missing id, name, and value.
For name, this means that the fields and their data are not submitted.
For value, on pages where submits send the user back to the form, this means that all values would be cleared out after form submission rather than being preserved in the form.
On the previous line you can see the label is using the node.id, so using this in the input for id and name. Using the form fields data as the input's value.