feedback: rename no trips/service states

mbta · Nov 2, 2023 · 109c445 · 109c445
1 parent 9834fff
commit 109c445
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 16 deletions.
diff --git a/apps/site/assets/ts/stop/__tests__/DepartureListTest.tsx b/apps/site/assets/ts/stop/__tests__/DepartureListTest.tsx
@@ -192,7 +192,7 @@ describe("DepartureList", () => {
     ).toBeDefined();
   });
 
-  it("should render `No upcoming trips today` if there are no schedules", () => {
+  it("should render `No more trips today` if there are no schedules", () => {
     render(
       <DepartureList
         alerts={[]}
@@ -204,7 +204,7 @@ describe("DepartureList", () => {
         hasService={true}
       />
     );
-    expect(screen.getByText("No upcoming trips today")).toBeDefined();
+    expect(screen.getByText("No more trips today")).toBeDefined();
   });
 
   it("should display cancelled if the trip has been cancelled", () => {
@@ -308,7 +308,7 @@ describe("DepartureList", () => {
   });
 
   it("can show no service message", () => {
-    const expectedMessage = "No service today";
+    const expectedMessage = "No trips today";
     render(
       <DepartureList
         route={route}

diff --git a/apps/site/assets/ts/stop/__tests__/__snapshots__/StopPageDeparturesTest.tsx.snap b/apps/site/assets/ts/stop/__tests__/__snapshots__/StopPageDeparturesTest.tsx.snap
@@ -88,7 +88,7 @@ exports[`StopPageDepartures renders with data 2`] = `
             <div
               class="font-helvetica-neue fs-14 u-nowrap"
             >
-              No upcoming trips
+              No more trips today
             </div>
           </div>
           <div>
@@ -115,7 +115,7 @@ exports[`StopPageDepartures renders with data 2`] = `
             <div
               class="font-helvetica-neue fs-14 u-nowrap"
             >
-              No upcoming trips
+              No more trips today
             </div>
           </div>
           <div>
@@ -142,7 +142,7 @@ exports[`StopPageDepartures renders with data 2`] = `
             <div
               class="font-helvetica-neue fs-14 u-nowrap"
             >
-              No upcoming trips
+              No more trips today
             </div>
           </div>
           <div>
@@ -191,7 +191,7 @@ exports[`StopPageDepartures renders with data 2`] = `
             <div
               class="font-helvetica-neue fs-14 u-nowrap"
             >
-              No upcoming trips
+              No more trips today
             </div>
           </div>
           <div>

diff --git a/apps/site/assets/ts/stop/__tests__/components/DepartureTimesTest.tsx b/apps/site/assets/ts/stop/__tests__/components/DepartureTimesTest.tsx
@@ -459,7 +459,7 @@ describe("DepartureTimes", () => {
     });
   });
 
-  it("renders 'No upcoming trips' when no predictions or schedules", async () => {
+  it("renders 'No more trips' when no predictions or schedules", async () => {
     renderWithRouter(
       <DepartureTimes
         headsign="Alewife"
@@ -471,7 +471,7 @@ describe("DepartureTimes", () => {
       />
     );
     await waitFor(() => {
-      expect(screen.getByText("No upcoming trips")).toBeDefined();
+      expect(screen.getByText("No more trips today")).toBeDefined();
       expect(screen.getByText("Alewife")).toBeDefined();
     });
   });
@@ -524,7 +524,7 @@ describe("DepartureTimes", () => {
   });
 
   it("can show no service message", async () => {
-    const expectedMessage = "No service today";
+    const expectedMessage = "No trips today";
     renderWithRouter(
       <DepartureTimes
         headsign="Some place"

diff --git a/apps/site/assets/ts/stop/components/DepartureList.tsx b/apps/site/assets/ts/stop/components/DepartureList.tsx
@@ -23,7 +23,7 @@ interface DepartureListProps {
 }
 
 const displayNoUpcomingTrips = (
-  message = "No upcoming trips today"
+  message = "No more trips today"
 ): JSX.Element => {
   return (
     <div className="c-alert-item--low m-8 d-flex justify-content-center align-items-center pb-40 pt-40">
@@ -59,9 +59,7 @@ const DepartureList = ({
 
   const noTrips =
     modeSpecificDepartures.length === 0 && displayNoUpcomingTrips();
-  const noService =
-    !hasService &&
-    displayNoUpcomingTrips(`No service today, ${todayDateString()}`);
+  const noService = !hasService && displayNoUpcomingTrips("No trips today");
   const noServiceOrNoTrips = noService || noTrips;
 
   return (

diff --git a/apps/site/assets/ts/stop/components/DepartureTimes.tsx b/apps/site/assets/ts/stop/components/DepartureTimes.tsx
@@ -77,13 +77,13 @@ const DepartureTimes = ({
               <div className="departure-card__times">{timeList}</div>
             ) : (
               <div className="font-helvetica-neue fs-14 u-nowrap">
-                No upcoming trips
+                No more trips today
               </div>
             )}
           </DeparturesWithBadge>
         ) : (
           <div className="font-helvetica-neue fs-14 u-nowrap">
-            No service today
+            No trips today
           </div>
         )}
       </div>