feat(OpenTripPlanner): add stop ID to response

mbta · Nov 7, 2023 · f3ed9ba · f3ed9ba
1 parent 7efbea4
commit f3ed9ba
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/apps/trip_plan/lib/trip_plan/api/open_trip_planner.ex b/apps/trip_plan/lib/trip_plan/api/open_trip_planner.ex
@@ -178,13 +178,19 @@ defmodule TripPlan.Api.OpenTripPlanner do
             lon
             departureTime
             arrivalTime
+            stop {
+              gtfsId
+            }
           }
           to {
             name
             lat
             lon
             departureTime
             arrivalTime
+            stop {
+              gtfsId
+            }
           }
           route {
             gtfsId

diff --git a/apps/trip_plan/lib/trip_plan/api/open_trip_planner/parser.ex b/apps/trip_plan/lib/trip_plan/api/open_trip_planner/parser.ex
@@ -97,8 +97,8 @@ defmodule TripPlan.Api.OpenTripPlanner.Parser do
       start: parse_time(json["startTime"]),
       stop: parse_time(json["endTime"]),
       mode: parse_mode(json),
-      from: parse_named_position(json["from"], "stopId"),
-      to: parse_named_position(json["to"], "stopId"),
+      from: parse_named_position(json["from"], "stop"),
+      to: parse_named_position(json["to"], "stop"),
       polyline: json["legGeometry"]["points"],
       name: json["route"],
       long_name: json["routeLongName"],
@@ -108,6 +108,17 @@ defmodule TripPlan.Api.OpenTripPlanner.Parser do
     }
   end
 
+  def parse_named_position(json, "stop") do
+    stop = json["stop"]
+
+    %NamedPosition{
+      name: json["name"],
+      stop_id: if(stop, do: id_after_colon(stop["gtfsId"])),
+      longitude: json["lon"],
+      latitude: json["lat"]
+    }
+  end
+
   def parse_named_position(json, id_field) do
     %NamedPosition{
       name: json["name"],