Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup: add LiveView support #1772

Merged
merged 6 commits into from
Oct 19, 2023
Merged

fixup: add LiveView support #1772

merged 6 commits into from
Oct 19, 2023

Conversation

thecristen
Copy link
Collaborator

@thecristen thecristen commented Oct 17, 2023

Summary of changes

Asana Ticket: No ticket

These changes should've been part of the upgrade to Phoenix 1.6 -- it's just some setup and configuration to support LiveView. I mostly followed the steps described in How to Setup Phoenix LiveView. This PR doesn't add any LiveViews or LiveComponents yet :)


General checks

  • Are the changes organized into self-contained commits with descriptive and well-formatted commit messages? This is a good practice that can facilitate easier reviews.
  • Testing. Do the changes include relevant passing updates to tests? This includes updating screenshots. Preferably tests are run locally to verify that there are no test failures created by these changes, before opening a PR.
  • Tech debt. Have you checked for tech debt you can address in the area you're working in? This can be a good time to address small issues, or create Asana tickets for larger issues.

@thecristen thecristen requested a review from a team as a code owner October 17, 2023 21:35
@thecristen thecristen requested a review from i0sea October 17, 2023 21:35
@thecristen
Copy link
Collaborator Author

I have no idea why the package-lock changes so much here.

@thecristen thecristen added the dev-green Deploy to dev-green label Oct 18, 2023
@thecristen thecristen temporarily deployed to dev-green October 18, 2023 00:29 — with GitHub Actions Inactive
@thecristen thecristen merged commit b7f89b3 into master Oct 19, 2023
26 of 29 checks passed
@thecristen thecristen deleted the cbj/livesocket-setup branch October 19, 2023 17:29
@thecristen thecristen removed the dev-green Deploy to dev-green label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants