Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autocomplete): link to text fragment #1783

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Conversation

thecristen
Copy link
Collaborator

Summary of changes

Asana Ticket: 🔍 Search | Flex Pass Search Bug

Making use of a browser feature called Text Fragments in order to have the search box navigate to a section of arbitrary text on the page. See the Asana issue for context behind why I decided to take that approach.

More resources around the browser feature:


General checks

  • Are the changes organized into self-contained commits with descriptive and well-formatted commit messages? This is a good practice that can facilitate easier reviews.
  • Testing. Do the changes include relevant passing updates to tests? This includes updating screenshots. Preferably tests are run locally to verify that there are no test failures created by these changes, before opening a PR.

@thecristen thecristen requested a review from a team as a code owner October 27, 2023 15:58
@thecristen thecristen requested review from i0sea and removed request for a team October 27, 2023 15:58
Base automatically changed from cbj/header-autocomplete to master November 1, 2023 15:26
@thecristen thecristen merged commit aae4e1d into master Nov 1, 2023
19 of 20 checks passed
@thecristen thecristen deleted the cbj/link-to-text branch November 1, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants