fix(navigation): fix tab order and layout shift #1793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when toggling the menu, don't collapse the space occupied by the scrollbar
i0sea
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: Address keyboard navigation issues with header navigation bar
Asana Ticket: Opening navbar dropdowns shifts whole page
The first was addressed by changing a CSS property; setting
display: nonetakes the element out of the accessibility tree, thus it's not reachable via tab key.The second needed the addition of
{ reserveScrollBarGap: true }to thedisableBodyScrollcall, along with some CSS and JS hackery to get the expanded menu and the background grey cover to look decent.