Rewrite MBTA Api using Req instead of HTTPoison #1999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonyshull
force-pushed
the
ags/rewrite-mbta-api
branch
from
fd67380 to
19719fc
Compare
anthonyshull
commented
Apr 22, 2024
Comment on lines
+111
to
+114
| base_url: System.get_env("MBTA_API_BASE_URL"), | ||
| enable_experimental_features: System.get_env("MBTA_API_ENABLE_EXPERIMENTAL_FEATURES"), | ||
| key: System.get_env("MBTA_API_KEY"), | ||
| version: System.get_env("MBTA_API_VERSION", "2019-07-01") |
There was a problem hiding this comment.
📓 I am renaming all of these ENV vars to be in line with what they do
thecristen
reviewed
Apr 24, 2024
kotva006
reviewed
Apr 24, 2024
kotva006
approved these changes
Apr 24, 2024
anthonyshull
force-pushed
the
ags/rewrite-mbta-api
branch
from
acdf63a to
521f342
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.asana.com/0/555089885850811/1206825410497903/f
We want to instrument calls to the MBTA Api with telemetry. Req uses Finch which does that out of the box. It also does other things automatically like decompressing gzip. So, it makes sense to just switch to using Req.
Devops PR: https://github.com/mbta/devops/pull/1730