-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(force_ssl): Configure force_ssl in prod instead of runtime #2035
Conversation
config/prod.exs
Outdated
@@ -2,3 +2,13 @@ import Config | |||
|
|||
config :dotcom, :cache, Dotcom.Cache.Multilevel | |||
config :dotcom, :trip_plan_feedback_cache, Dotcom.Cache.TripPlanFeedback.Cache | |||
|
|||
unless System.get_env("PORT") do | |||
# configured separately so that we can have the health check not require |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Is this unless
needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a holdover from many moons ago added here to help Backstop testing that we don't do anymore. https://github.com/mbta/dotcom-legacy/commit/0d8b53a42016da6b5cec3506f79c5fcbb170b095 We can probably revert that to how it was before
There is also config for this in |
Summary of changes
Move the
force_ssl
configuration to theprod.exs
configuration file as it is not supported to be configured in theruntime.exs
filehttps://app.asana.com/0/555089885850811/1206388063560698