Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use short date format on trip planner #2130

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Conversation

bklebe
Copy link
Contributor

@bklebe bklebe commented Jul 18, 2024

Summary of changes

Asana Ticket: Shorten trip planner date/time format on input


General checks

  • Are the changes organized into self-contained commits with descriptive and well-formatted commit messages? This is a good practice that can facilitate easier reviews.
  • Testing. Do the changes include relevant passing updates to tests? This includes updating screenshots. Preferably tests are run locally to verify that there are no test failures created by these changes, before opening a PR.
  • Tech debt. Have you checked for tech debt you can address in the area you're working in? This can be a good time to address small issues, or create Asana tickets for larger issues.

New UI, or substantial UI changes

  • Cross-browser compatibility is less of an issue now that we're no longer supporting IE, but changes still need to work as expected in Safari, Chrome, and Firefox.
  • Are interactive elements accessible? This includes at minimum having relevant keyboard interactions and visible focus, but can also include verification with screen reader testing.
  • Other accessibility checks such as sufficient color constrast, or whether the layout holds up at 200% zoom level.

@bklebe bklebe force-pushed the bak/fix-date-overflow branch 2 times, most recently from 423e56f to 441222e Compare July 23, 2024 14:08
@bklebe
Copy link
Contributor Author

bklebe commented Jul 23, 2024

Screenshot 2024-07-23 at 10 10 24

@bklebe
Copy link
Contributor Author

bklebe commented Jul 23, 2024

Not sure if we need tests for this or how that should be handled, there don't seem to be any existing? Anyway happy to add some given some guidance.

@bklebe bklebe marked this pull request as ready for review July 23, 2024 14:12
@bklebe bklebe requested a review from a team as a code owner July 23, 2024 14:12
@bklebe bklebe requested a review from anthonyshull July 23, 2024 14:12
@bklebe bklebe merged commit 13b5db7 into main Jul 23, 2024
29 checks passed
@bklebe bklebe deleted the bak/fix-date-overflow branch July 23, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants