chore: Phoenix 1.7

[bklebe]

Summary of changes

Asana Ticket: [monthly] Upgrade Erlang, Elixir & dependencies

Upgrades to Phoenix 1.7 per the upgrade guide. This includes removing functionality to add a not-found class to the body tag on 404 pages (because a) it's broken by this upgrade, b) it relies on Phoenix internals, c) it appears to be unused), migrating deprecated usage of Phoenix.Controller.get_flash/2 to Phoenix.Flash.get/2, and updating .formatter.exs to include HEEx files and the new Phoenix.LiveView.HTMLFormatter plugin.

---

General checks

• Are the changes organized into self-contained commits with descriptive and well-formatted commit messages? This is a good practice that can facilitate easier reviews.
• Testing. Do the changes include relevant passing updates to tests? This includes updating screenshots. Preferably tests are run locally to verify that there are no test failures created by these changes, before opening a PR.
• Tech debt. Have you checked for tech debt you can address in the area you're working in? This can be a good time to address small issues, or create Asana tickets for larger issues.

[thecristen]

Looks pretty good overall!

One bug I found: I noticed that one backend endpoint returns a 500 error (example url: https://dev-green.mbtace.com/schedules/line_api/realtime?id=749&direction_id=1) and predictions and vehicles aren't showing within the line diagram. Could one of the updated dependencies have altered how Phoenix handles serving JSON?

Log from Splunk:

dc79b8312c8b Request: GET /schedules/line_api/realtime?id=Orange&direction_id=1
dc79b8312c8b ** (exit) an exception was raised:
dc79b8312c8b     ** (FunctionClauseError) no function clause matching in Jason.Encoder.Routes.Route."-inlined-encode/2-"/2
dc79b8312c8b         (dotcom 0.0.1) Jason.Encoder.Routes.Route."-inlined-encode/2-"(%{id: "Orange", name: "Orange Line", type: 1, description: :rapid_transit, sort_order: 10020, __struct__: Routes.Route, color: "ED8B00", long_name: "Orange Line", direction_destinations: %{0 => "Forest Hills", 1 => "Oak Grove"}, direction_names: %{0 => "Southbound", 1 => "Northbound"}, fare_class: :rapid_transit_fare, line_id: "line-Orange", custom_route?: false}, {#Function<3.64988371/3 in Jason.Encode.escape_json>, #Function<1.64988371/3 in Jason.Encode.map_naive>})
dc79b8312c8b         (dotcom 0.0.1) lib/schedules/schedule.ex:8: Jason.Encoder.Schedules.Schedule.encode/2
dc79b8312c8b         (dotcom 0.0.1) lib/predicted_schedule.ex:14: Jason.Encoder.PredictedSchedule.encode/2
dc79b8312c8b         (jason 1.4.4) lib/encode.ex:198: Jason.Encode.map_naive_loop/3
dc79b8312c8b         (jason 1.4.4) lib/encode.ex:189: Jason.Encode.map_naive/3
dc79b8312c8b         (jason 1.4.4) lib/encode.ex:159: Jason.Encode.list/3
dc79b8312c8b         (jason 1.4.4) lib/encode.ex:198: Jason.Encode.map_naive_loop/3
dc79b8312c8b         (jason 1.4.4) lib/encode.ex:199: Jason.Encode.map_naive_loop/3

[bklebe]

Thanks for the heads up, I'll look into this.

[thecristen]

Let's try it out on dev!