Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improved install command #2267

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/actions/setup-all/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,5 +58,4 @@ runs:
shell: bash
run: |
git config --global url."https://github.com/".insteadOf ssh://[email protected]/
npm install --prefix assets --package-lock-only
npm run install:ci
npm run assets:install:ci
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ jobs:
priv
react_renderer/dist/app.js
key: ci-application-cache-${{ github.sha }}
- run: npm install --prefix assets -S -install-links deps/mbta_metro/priv/
- run: npm run assets:install:ci
- run: npm --prefix assets run webpack:build
- run: npm --prefix assets run webpack:build:react
- run: mix compile --all-warnings
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ Welcome to [Dotcom](https://www.notion.so/mbta-downtown-crossing/Dotcom-6aa7b0f0

1. Install our Node dependencies. From the root of this repo:
```
npm run install
npm run assets:install
```
You won't see a `node_modules` folder at the root of this project -- this installs packages into `assets`.

Expand Down
Loading
Loading