fix(TripPlanner.Results): various small things #2307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlarson
reviewed
Jan 7, 2025
| defp leg_icon(%{routes: [], walk_minutes: _} = assigns) do | ||
| ~H""" | ||
| <span class={[ | ||
| "flex items-center gap-1 text-sm font-semibold leading-none whitespace-nowrap py-1 px-2 rounded-full border border-solid border-gray-light", | ||
| "flex items-center gap-1 text-sm font-semibold leading-none whitespace-nowrap py-1 px-2 rounded-full border-[1px] border-gray-light", |
There was a problem hiding this comment.
This is bugging me, because according to Tailwind's docs, border should do the same thing as border-[1px], but it's not!
joshlarson
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Tickets completed as individual commits.
Asana Ticket: Walking pills should have a 1px border radius
Pretty sure he meant 1px border width.
Asana Ticket: Correctly pluralize similar trips
Adds the correct phrasing.
Bonus: I figured out how to display ordinal dates to match the Figma mock.
So now it says "January 6th" instead of "January 6".
Asana Ticket: Clicking anywhere on a result card should open the details view
I decided to leave the relevant Phoenix data attributes on the "Details" button despite the fact they're duplicating the functionality of clicking on the
<div>... it felt more "right" to me, makes clicking around in tests easier, Phoenix complains if you try to click a thing which doesn't have those attributes... and it doesn't seem to hurt anything to have thephx-clickon both the "Details" link and the overall div.