Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tripPlanner): Restore error message if from and to are the same #2313

Merged
merged 2 commits into from
Jan 9, 2025
Merged

fix(tripPlanner): Restore error message if from and to are the same #2313

merged 2 commits into from
Jan 9, 2025

Conversation

joshlarson
Copy link
Contributor

This fixes a bug introduced in #2309 (oops!)

Before

Screenshot 2025-01-08 at 1 07 17 PM (Note the lack of error message, but also the lack of actually doing a trip plan)

After

Screenshot 2025-01-08 at 1 05 55 PM

Asana Ticket: Trip Planner | Restore error state for origin == destination

Follow-up to:

@joshlarson joshlarson requested a review from a team as a code owner January 8, 2025 18:08
@joshlarson joshlarson enabled auto-merge (squash) January 8, 2025 18:08
@joshlarson joshlarson merged commit 3487745 into main Jan 9, 2025
17 checks passed
@joshlarson joshlarson deleted the jdl/restore-same-from-to-error-message branch January 9, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thecristen thecristen thecristen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshlarson @thecristen