Change the tab order of itineraries and the map #2325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlarson
requested changes
Jan 13, 2025
There was a problem hiding this comment.
This almost works, but makes the order wrong on mobile. I think replacing flex-col with flex-col-reverse on the parent div would do the trick.
Related: there's an md:order-last on the map component, which I think you could remove now, since it's now DOM-ordered-last 😅
joshlarson
reviewed
Jan 13, 2025
lib/dotcom_web/live/trip_planner.ex
Outdated
Comment on lines
87
to
88
| @results.itinerary_group_selection == nil && "hidden md:block", | ||
| @results.itinerary_group_selection != nil && "block" |
There was a problem hiding this comment.
I'm pretty sure we still want this logic, since we only want the map to show up if you're looking at a specific itinerary. (Unless that part of the design changed?)
joshlarson
requested changes
Jan 13, 2025
There was a problem hiding this comment.
Unless I missed something, we still don't want the map to render on mobile unless an itinerary is selected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.asana.com/0/555089885850811/1209110864370903/f
I just changed the order of the elements in the DOM.