refactor(TripPlan.ItineraryGroups): improve handling for "arrive by" selection #2329
+357
−144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix the displayed summary so that it reflects the chosen itinerary from the group - move (and rename) the 'depart at buttons' to same level as itinerary_summary and itinerary_detail - fix which button from the group is the initially active one - adjust the display to better describe 'arrive by' results - adjust ItineraryGroups.from_itineraries/2 to take 5 groups *after* sorting - add more docs all around
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: TP | Show appropriate itineraries for the "Arrive by" selection and TP | Alternate time selection should be reflected in the itinerary summary
The main crux is that, when the user selects "arrive by" instead of the default or "leave at" time, many of our code's assumptions turned out to be false... so this PR makes a slew of changes around that.
ItineraryGroups.from_itineraries/2to take 5 groups after all the sorting