Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep input form params in URL #2339

Closed
wants to merge 13 commits into from
Closed

Keep input form params in URL #2339

wants to merge 13 commits into from

Conversation

anthonyshull
Copy link
Contributor

@anthonyshull anthonyshull marked this pull request as ready for review January 21, 2025 18:12
@anthonyshull anthonyshull requested a review from a team as a code owner January 21, 2025 18:12
thecristen
thecristen requested changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@thecristen thecristen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is clean!

  1. One thing I notice is the input displays the coordinates – it should show the name.

For example, /to/Alewife shows this:

image
  1. I left a comment elsewhere but this blocks release and I wasn't sure if that's what you wanted.

lib/dotcom_web/controllers/trip_plan_controller.ex Show resolved Hide resolved
@thecristen thecristen added the do not merge ⏳ it's waiting on something label Jan 22, 2025
@anthonyshull anthonyshull mentioned this pull request Jan 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thecristen thecristen thecristen approved these changes

Assignees
No one assigned
Labels
do not merge ⏳ it's waiting on something
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anthonyshull @thecristen