chore: upgrade versions to support xcode 16 #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaylaBrady
changed the title
boringcactus
approved these changes
Oct 9, 2024
|
There are some ongoing XCode 16 issues with ViewInspector that aren't trivially resolved, including Going to hold off on trying to further complete this upgrade for now. |
KaylaBrady
commented
Oct 16, 2024
There was a problem hiding this comment.
@boringcactus your changes look great to me, thanks for getting this over the line! I'm not able to formally approve since I started the PR, but your changes get a ✅ from me!
| import SwiftUI | ||
| import ViewInspector | ||
|
|
||
| extension InspectableView { |
There was a problem hiding this comment.
praise: I really like the way you extracted this out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
No ticket.
What is this PR for?
This bumps dependency versions to be compatible with Xcode 16 (slack thread).
Testing
What testing have you done?
Confirmed I was able to build & run the app locally. However, I do now see a warning:
empty dSYM file detected, dSYM was created with an executable with no debug info..There is a developer forum thread on this new warning, with Sentry 8.36.0 specifically mentioned.
Apple developer response:
I built an archive locally and confirmed dSYM files are present in the build.
