Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump com.google.firebase:firebase-bom from 33.7.0 to 33.8.0 #665

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Merge branch 'main' into dependabot/gradle/com.google.firebase-fireba…

b60e5cb
Select commit
Loading
Failed to load commit list.
Open

build(deps): bump com.google.firebase:firebase-bom from 33.7.0 to 33.8.0 #665

Merge branch 'main' into dependabot/gradle/com.google.firebase-fireba…
b60e5cb
Select commit
Loading
Failed to load commit list.
Xcode Cloud / MBTA Transit Staging | PR Branch Workflow | iosAppRetries - iOS succeeded Feb 3, 2025 in 27m 46s

1 test failure, 62 warnings

Report Summary
Errors 0
Test Failures 1
Analysis Issues 0
Warnings 62

Details

1 Test Failure

Details

  MorePageTests.testLinksExist() | iosApp/iosAppTests/Pages/Settings/MorePageTests.swift:120
      Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "Inspection at line 106".

62 Warnings

Details

  iosApp/iosApp/Utils/RouteTypeExtension.swift:18
      Void Function in Ternary Violation: Using ternary to call Void functions should be avoided (void_function_in_ternary)
  iosApp/iosAppUITests/HomeMapViewUITests.swift:79
      Initialization of immutable value 'springboard' was never used; consider replacing with assignment to '_' or removing it
  iosApp/iosApp/Fetchers/ViewportProvider.swift:150
      Unused Optional Binding Violation: Prefer `!= nil` over `let _ =` (unused_optional_binding)
  iosApp/iosApp/Pages/Map/HomeMapViewHandlerExtension.swift:166
      Immutable value 'tripFilter' was never used; consider replacing with '_' or removing it
  iosApp/iosApp/Pages/More/MoreSection.swift:38
      Line Length Violation: Line should be 120 characters or less; currently it has 122 characters (line_length)
  iosApp/iosApp/Pages/Onboarding/OnboardingScreenView.swift:148
      Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
  iosApp/iosApp/Pages/Map/AnnotatedMap.swift:35
      'MapContentGestureContext' is deprecated: renamed to 'InteractionContext'
  iosApp/iosAppTests/Pages/Map/MapViewModelTests.swift:20
      Initialization of immutable value 'mapVM' was never used; consider replacing with assignment to '_' or removing it
  iosApp/iosApp/Pages/Onboarding/OnboardingScreenView.swift:144
      Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
  iosApp/iosApp/ComponentViews/SheetNavigationLink.swift:21
      Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
  iosApp/iosAppTests/ViewModels/StopDetailsViewModelTests.swift:59
      Instance method 'wait' is unavailable from asynchronous contexts; Use await fulfillment(of:timeout:enforceOrder:) instead; this is an error in Swift 6
  iosApp/iosApp/ViewModels/SearchViewModel.swift:127
      Redundant Optional Initialization Violation: Initializing an optional variable with nil is redundant (redundant_optional_initialization)
  iosApp/iosApp/ViewModels/StopDetailsViewModel.swift:502
      File Length Violation: File should contain 400 lines or less: currently contains 502 (file_length)
  iosApp/iosApp/Pages/StopDetails/ExplainerPage.swift:107
      Line Length Violation: Line should be 120 characters or less; currently it has 180 characters (line_length)
  iosApp/iosAppTests/ViewModels/ErrorBannerViewModelTests.swift:24
      Instance method 'wait' is unavailable from asynchronous contexts; Use await fulfillment(of:timeout:enforceOrder:) instead; this is an error in Swift 6
  iosApp/iosApp/ViewModels/SettingsViewModel.swift:113
      Line Length Violation: Line should be 120 characters or less; currently it has 123 characters (line_length)
  iosApp/iosApp/ContentView.swift:356
      Large Tuple Violation: Tuples should have at most 2 members (large_tuple)
  iosApp/iosApp/Pages/LegacyStopDetails/StopDetailsFilteredRouteView.swift:232
      Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
  iosApp/iosApp/Pages/StopDetails/TripHeaderCard.swift:143
      Line Length Violation: Line should be 120 characters or less; currently it has 143 characters (line_length)
  iosApp/iosApp/ViewModels/SettingsViewModel.swift:97
      Line Length Violation: Line should be 120 characters or less; currently it has 137 characters (line_length)
  iosApp/iosApp/Utils/FetchApi.swift:35
      Immutable value 'error' was never used; consider replacing with '_' or removing it
  iosApp/iosApp/Pages/StopDetails/ExplainerPage.swift:139
      Line Length Violation: Line should be 120 characters or less; currently it has 175 characters (line_length)
  iosApp/iosApp/Utils/FormattedAlert.swift:15
      Cyclomatic Complexity Violation: Function should have complexity 10 or less; currently complexity is 11 (cyclomatic_complexity)
  iosApp/iosApp/Pages/StopDetails/StopDetailsFilteredView.swift:41
      Function Body Length Violation: Function body should span 50 lines or less excluding comments and whitespace: currently spans 51 lines (function_body_length)
  iosApp/iosApp/Pages/StopDetails/TripStopRow.swift:162
      Line Length Violation: Line should be 120 characters or less; currently it has 121 characters (line_length)
  iosApp/iosApp/ViewModels/SettingsViewModel.swift:71
      Line Length Violation: Line should be 120 characters or less; currently it has 150 characters (line_length)
  iosApp/iosApp/Pages/TripDetails/TripDetailsPage.swift:14
      Type Body Length Violation: Type body should span 250 lines or less excluding comments and whitespace: currently spans 308 lines (type_body_length)
  iosApp/iosApp/Pages/Map/HomeMapViewHandlerExtension.swift:296
      Todo Violation: TODOs should be resolved (figure out something to do if ...) (todo)
  iosApp/iosAppTests/Views/OptionalNavigationLinkTests.swift:41
      Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
  iosApp/iosApp/Pages/StopDetails/ExplainerPage.swift:118
      Line Length Violation: Line should be 120 characters or less; currently it has 132 characters (line_length)
  iosApp/iosApp/Utils/UIWindowExtension.swift:16
      Prefer For-Where Violation: `where` clauses are preferred over a single `if` inside a `for` (for_where)
  iosApp/iosApp/Pages/StopDetails/StopDetailsNoTripCard.swift:57
      Line Length Violation: Line should be 120 characters or less; currently it has 132 characters (line_length)
  iosApp/iosApp/Pages/Map/MapHttpInterceptor.swift:31
      Immutable value 'error' was never used; consider replacing with '_' or removing it
  iosApp/iosApp/Pages/StopDetails/TripHeaderCard.swift:150
      Line Length Violation: Line should be 120 characters or less; currently it has 128 characters (line_length)
  iosApp/iosApp/ViewModels/ErrorBannerViewModel.swift:17
      Redundant Optional Initialization Violation: Initializing an optional variable with nil is redundant (redundant_optional_initialization)
  iosApp/iosApp/Pages/NearbyTransit/NearbyTransitView.swift:16
      Type Body Length Violation: Type body should span 250 lines or less excluding comments and whitespace: currently spans 318 lines (type_body_length)
  iosApp/iosApp/Pages/NearbyTransit/DestinationRowView.swift:95
      Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
  iosApp/iosApp/Pages/LegacyStopDetails/StopDetailsFilterPills.swift:81
      Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
  iosApp/iosApp/Pages/Map/HomeMapViewHandlerExtension.swift:257
      'MapContentGestureContext' is deprecated: renamed to 'InteractionContext'
  iosApp/iosApp/Pages/Map/MapLayerManager.swift:73
      Line Length Violation: Line should be 120 characters or less; currently it has 123 characters (line_length)
  iosApp/iosApp/Pages/StopDetails/TripStopRow.swift:157
      Line Length Violation: Line should be 120 characters or less; currently it has 128 characters (line_length)
  iosApp/iosApp/ComponentViews/ActionButton.swift:78
      Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
  iosApp/iosApp/Utils/FormattedAlert.swift:16
      Todo Violation: TODOs should be resolved (Add all possible alert effects...) (todo)
  iosApp/iosApp/Utils/RouteTypeExtension.swift:23
      Void Function in Ternary Violation: Using ternary to call Void functions should be avoided (void_function_in_ternary)
  iosApp/iosAppTests/ViewModels/StopDetailsViewModelTests.swift:25
      Using '_' to ignore the result of a Void-returning function is redundant
  iosApp/iosApp/ViewModels/SettingsViewModel.swift:89
      Line Length Violation: Line should be 120 characters or less; currently it has 124 characters (line_length)
  iosApp/iosApp/Pages/AlertDetails/AlertDetails.swift:354
      Line Length Violation: Line should be 120 characters or less; currently it has 137 characters (line_length)
  iosApp/iosApp/Pages/StopDetails/TripHeaderCard.swift:179
      Void Function in Ternary Violation: Using ternary to call Void functions should be avoided (void_function_in_ternary)
  iosApp/iosApp/ComponentViews/LocationAuthButton.swift:85
      Line Length Violation: Line should be 120 characters or less; currently it has 137 characters (line_length)
  iosApp/iosAppTests/Pages/NearbyTransit/RouteCardTests.swift:22
      Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
  iosApp/iosApp/Pages/StopDetails/TripStops.swift:138
      Line Length Violation: Line should be 120 characters or less; currently it has 125 characters (line_length)
  iosApp/iosApp/ComponentViews/UpcomingTripView.swift:150
      Line Length Violation: Line should be 120 characters or less; currently it has 143 characters (line_length)
  iosApp/iosApp/Pages/NearbyTransit/DestinationRowView.swift:69
      Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
  iosApp/iosApp/Pages/Onboarding/OnboardingScreenView.swift:81
      Line Length Violation: Line should be 120 characters or less; currently it has 139 characters (line_length)
  iosApp/iosApp/Pages/Onboarding/OnboardingScreenView.swift:134
      Line Length Violation: Line should be 120 characters or less; currently it has 124 characters (line_length)
  iosApp/iosApp/ProductionAppView.swift:84
      Expression implicitly coerced from 'URLResponse?' to 'Any'
  iosApp/iosApp/Pages/StopDetails/TripDetailsView.swift:114
      Function Parameter Count Violation: Function should have 5 parameters or less: it currently has 6 (function_parameter_count)
  iosApp/iosApp/Utils/RouteTypeExtension.swift:21
      Void Function in Ternary Violation: Using ternary to call Void functions should be avoided (void_function_in_ternary)
  iosApp/iosApp/ComponentViews/ErrorBanner.swift:56
      Line Length Violation: Line should be 120 characters or less; currently it has 126 characters (line_length)
  iosApp/iosApp/Pages/NearbyTransit/NearbyTransitView.swift:570
      File Length Violation: File should contain 400 lines or less: currently contains 570 (file_length)
  iosApp/iosApp/Pages/More/MoreLink.swift:14
      Redundant Optional Initialization Violation: Initializing an optional variable with nil is redundant (redundant_optional_initialization)
  iosApp/iosApp/Pages/StopDetails/TripStopRow.swift:167
      Line Length Violation: Line should be 120 characters or less; currently it has 131 characters (line_length)