test(StopDetailsViewModel): Address remaining flakiness #682
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #675, which introduced some tests that are still flaky.
What is this PR for?
An attempt to resolve flakiness in the
stopDetailsManagedVM
tests. I expaned the use of the StandardTestDispatcher recommended here to the view model in each managedVM test. These tests passed running repeatedly locally, except fortestManagerHandlesTripFilterChange
which consistently failed until I also addedcomposeTestRule.awaitIdle()
I'm not entirely sure why that test in particular was failing.If these continue to flake after these changes, then we should take @EmmaSimon's suggestion of skipping them for now and make a ticket to follow up on them.
iOS
android
withContext(Dispatchers.Default)
where possibleTesting
What testing have you done?