Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(StopDetailsViewModel): Address remaining flakiness #682

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

KaylaBrady
Copy link
Collaborator

Summary

Follow up to #675, which introduced some tests that are still flaky.

What is this PR for?

An attempt to resolve flakiness in the stopDetailsManagedVM tests. I expaned the use of the StandardTestDispatcher recommended here to the view model in each managedVM test. These tests passed running repeatedly locally, except for testManagerHandlesTripFilterChange which consistently failed until I also added composeTestRule.awaitIdle() I'm not entirely sure why that test in particular was failing.

If these continue to flake after these changes, then we should take @EmmaSimon's suggestion of skipping them for now and make a ticket to follow up on them.

iOS

  • If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?
    • Add temporary machine translations, marked "Needs Review"

android

  • All user-facing strings added to strings resource
  • Expensive calculations are run in withContext(Dispatchers.Default) where possible

Testing

What testing have you done?

@KaylaBrady KaylaBrady requested a review from a team as a code owner January 24, 2025 20:38
@KaylaBrady KaylaBrady requested a review from EmmaSimon January 24, 2025 20:38
@KaylaBrady KaylaBrady merged commit f827614 into main Jan 24, 2025
5 checks passed
@KaylaBrady KaylaBrady deleted the kb-flaky-test-fix branch January 24, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants