Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Update to use dmc 0.15.1 Part 2 #960

Merged
merged 25 commits into from
Jan 21, 2025
Merged
Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
1a962f1
Update to use dmc 0.15.1
AnnMarieW Dec 7, 2024
7ff1b73
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 7, 2024
efbd801
Apply suggestions from code review
AnnMarieW Dec 12, 2024
7e1ff1c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 12, 2024
4a091d2
Update after review
AnnMarieW Dec 15, 2024
fd2aeff
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 15, 2024
4189fa8
added example app
AnnMarieW Dec 16, 2024
cfb1c3b
example of mantine style
AnnMarieW Dec 16, 2024
40aba6d
update after review
AnnMarieW Jan 6, 2025
c216c98
fixed tests
AnnMarieW Jan 6, 2025
e3d446c
update after review
AnnMarieW Jan 8, 2025
5b50548
Update vizro-core/src/vizro/models/_components/form/date_picker.py
AnnMarieW Jan 16, 2025
81c237b
Merge branch 'main' into dmc-15
huong-li-nguyen Jan 20, 2025
e7fa7bf
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 20, 2025
8df7ffa
Update vizro-core/pyproject.toml
antonymilne Jan 20, 2025
7205e85
Move mantine_dates.css into repo; remove external_stylesheet; delete …
antonymilne Jan 20, 2025
0e5c86b
Make layout children a list
antonymilne Jan 20, 2025
ed7c4ea
Add changelog
antonymilne Jan 20, 2025
dbcea5e
Merge branch 'main' into dmc-15
antonymilne Jan 20, 2025
704d850
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 20, 2025
d4d1a99
Fix merge
antonymilne Jan 20, 2025
b99adc0
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 20, 2025
3370839
Fix merge
antonymilne Jan 20, 2025
f5566ed
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 20, 2025
c8e29e4
Merge main into feature branch
petar-qb Jan 21, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .stylelintignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
**/static/css/vizro-bootstrap.min.css
**/static/css/vizro-bootstrap.min.css.map
**/static/css/mantine_dates.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
<!--
A new scriv changelog fragment.

Uncomment the section that is right (remove the HTML comment wrapper).
-->

<!--
### Highlights ✨

- A bullet item for the Highlights ✨ category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX. ([#1](https://github.com/mckinsey/vizro/pull/1))

-->
<!--
### Removed

- A bullet item for the Removed category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX. ([#1](https://github.com/mckinsey/vizro/pull/1))

-->
<!--
### Added

- A bullet item for the Added category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX. ([#1](https://github.com/mckinsey/vizro/pull/1))

-->

### Changed

- Bumped library used for `vm.DatePicker` to `dash_mantine_components~=0.15.1`. ([#924](https://github.com/mckinsey/vizro/pull/924))

<!--
### Deprecated

- A bullet item for the Deprecated category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX. ([#1](https://github.com/mckinsey/vizro/pull/1))

-->
<!--
### Fixed

- A bullet item for the Fixed category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX. ([#1](https://github.com/mckinsey/vizro/pull/1))

-->
<!--
### Security

- A bullet item for the Security category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX. ([#1](https://github.com/mckinsey/vizro/pull/1))

-->
2 changes: 1 addition & 1 deletion vizro-core/examples/dev/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -827,6 +827,6 @@ def multiple_cards(data_frame: pd.DataFrame, n_rows: Optional[int] = 1) -> html.
target="_blank",
className="anchor-container",
)
app.dash.layout.children = [app.dash.layout.children, banner]
app.dash.layout.children.append(banner)
server = app.dash.server
app.run()
9 changes: 9 additions & 0 deletions vizro-core/src/vizro/models/_dashboard.py
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,15 @@ def build(self):
theme={"primaryColor": "gray"},
)

# children=[layout] as a list rather than children=layout, so that app.dash.layout.children.append works to
# easily add things to the Dash layout. In future we might have a neater function for patching components into
# the Dash layout in which case this could change.
return dmc.MantineProvider(
children=[layout],
# Use the `theme` to style all Mantine components with a Vizro theme. For more info see https://www.dash-mantine-components.com/components/mantineprovider
theme={"primaryColor": "gray"},
)

def _validate_logos(self):
logo_img = self._infer_image(filename="logo")
logo_dark_img = self._infer_image(filename="logo_dark")
Expand Down
Loading
Loading