-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] Add reverse_color
argument to kpi_card_reference
#995
Conversation
View the example dashboards of the current commit live on PyCafe ☕ 🚀Updated on: 2025-02-05 14:50:00 UTC Link: vizro-core/examples/dev/ Link: vizro-core/examples/scratch_dev |
reverse_color
argument to kpi_card_reference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I enjoy reviewing your PRs 😄. This looks perfect!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! 💯
Should @l0uden update his tests to include this? I think he may have tests for KPI cards as components in a pure Dash app and within vizro.
I can just extend his tests 👍 Give me a sec, will update the screenshots as well. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Description
When we initially created the KPI card functions, we were already thinking about incorporating the
reverse_color
argument. Back then we decided to keep the API small and see whether it's even requested.It has been recently requested and is actually fairly simple to implement, so we've decided to introduce the argument now. See #976 for context.
reverse_color
argumentScreenshot
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":