Update SVG presentation attributes #23545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:svg
queengooborg
approved these changes
Jun 29, 2024
This was referenced Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SVG presentation attributes can be used on all SVG elements and they are also CSS properties. We have compat data for all them in the css.properties.* tree already. This PR uses the compat data from the css.properties.* tree in svg.global_attributes.* as well. (A lot of them are ranged values but I think that's better than the null values we have now)
Test results and supporting details
None, I'm assuming support is the same. We have always update the data later if we see discrepancies between SVG attribute and CSS property.
Related issues
#9462