Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure the timestamp validation checks the upper limit given in the ulid spec #27

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

somnam
Copy link
Contributor

@somnam somnam commented Jun 16, 2024

#26 (comment)

Based on a similar approach in ulid-py

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.61%. Comparing base (419116f) to head (0b82942).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
- Coverage   99.61%   99.61%   -0.01%     
==========================================
  Files           4        4              
  Lines         262      259       -3     
  Branches       66       66              
==========================================
- Hits          261      258       -3     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdomke
Copy link
Owner

mdomke commented Jun 17, 2024

@somnam thank you very much! I guess I was too much focused on creating ULIDs with legit datetime values, so that I didn't pay enough attention to the specification.

@mdomke mdomke merged commit 1d5ed28 into mdomke:main Jun 17, 2024
7 checks passed
@somnam
Copy link
Contributor Author

somnam commented Jun 18, 2024

@somnam thank you very much!

Thanks a lot for the merge and quick release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants