Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple select and removal in browser #220

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

mikejbuckingham
Copy link
Contributor

This PR fixes #198

For the time being, all we do here is enable selection of multiple rows, and provide the "Remove" functionality. In the future, it might be worth adding some extra options (such as view, but we need to decide how we're handling multiple-input views first (As mentioned in #218)

As we get cascade deletion of children when removing a parent, there is a situation where we're requesting th delete of an element that has already been removed. However, the DB code handles this quite gracefully, and I don't think it's the business of the viewer to intrude here. Would welcome feedback though (particularly as I plan to revisit the DB code in the near future)

@mikejbuckingham mikejbuckingham added this to the 2.3 milestone Jan 8, 2015
@@ -11,6 +11,8 @@

=========================================================================*/

#include <qnamespace.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like an internal Qt header, I don't think you should include it here.

@gpasquie
Copy link
Contributor

It seems to work well for multiple deletion, good stuff.
However, I think there are some problems.
First, as you updated the contextual menu when you have multiple items selected, you'll need to update the "actions" toolbox on the left panel, otherwise the user can still have the feeling he can view or export multiple items.
Moreover, and it's a bit more complicated I think, you'll have to manage moving several items in the db...We can imagine being able to move multiple series at the same time but what do you do when you have a serie and a study selected at the same time? Should we disable drag and drop?
Or maybe we should allow multiple selection only for the same types of items but I'm not sure this is easily doable...

@rdebroiz
Copy link
Member

rdebroiz commented Apr 2, 2015

Or maybe we should allow multiple selection only for the same types of items but I'm not sure this is easily doable...

+1

@ocommowi ocommowi modified the milestones: 3.0, 2.3 Jan 12, 2016
@ocommowi
Copy link
Contributor

Is this solved or not? Should it be in 3.0 ?

mathildemerle added a commit to mathildemerle/medInria-public that referenced this pull request Feb 17, 2017
[medSelectorToolBox]: Only one output even when the toolbox is used mu…
@mathildemerle mathildemerle removed this from the 3.0 milestone Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot select multiple files loaded in medInria
6 participants