-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple select and removal in browser #220
base: master
Are you sure you want to change the base?
Multiple select and removal in browser #220
Conversation
@@ -11,6 +11,8 @@ | |||
|
|||
=========================================================================*/ | |||
|
|||
#include <qnamespace.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like an internal Qt header, I don't think you should include it here.
It seems to work well for multiple deletion, good stuff. |
+1 |
Is this solved or not? Should it be in 3.0 ? |
[medSelectorToolBox]: Only one output even when the toolbox is used mu…
This PR fixes #198
For the time being, all we do here is enable selection of multiple rows, and provide the "Remove" functionality. In the future, it might be worth adding some extra options (such as view, but we need to decide how we're handling multiple-input views first (As mentioned in #218)
As we get cascade deletion of children when removing a parent, there is a situation where we're requesting th delete of an element that has already been removed. However, the DB code handles this quite gracefully, and I don't think it's the business of the viewer to intrude here. Would welcome feedback though (particularly as I plan to revisit the DB code in the near future)