This repository has been archived by the owner on Dec 14, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 87
[RFR] Print test failures in GH Actions #765
Open
jtotoole
wants to merge
26
commits into
master
Choose a base branch
from
jot-print-test-fails
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
3defc66
print test fails in gh build
jtotoole 15f7a63
debug
jtotoole 7d67d14
add sys.exit
jtotoole 5634c27
add ACTION_STEP_DEBUG: true
jtotoole fcd9c66
clean up build.yml
jtotoole 1a475d0
keep it simple, stupid
jtotoole fff951f
Delete gh_actions_print_test_failures.py
jtotoole f7f213b
move awk into test run step
jtotoole a16e1be
chmod on joblog.txt
jtotoole e8b1a91
Merge branch 'master' of https://github.com/mediacloud/backend into j…
jtotoole d12985b
remove some tests
jtotoole 741af3f
Revert "remove some tests"
jtotoole 9df3331
remove a bunch of tests
jtotoole cba39a7
try exit code 1 on run tests
jtotoole d5c0ff7
try GHA conditional
jtotoole 89bcc6c
restart build
jtotoole 9570840
use cat to print test fails
jtotoole 22ecb40
debug with tmate
jtotoole 2f6e85b
always run tmate
jtotoole 3394f4d
awk correct log file
jtotoole 23a3e9c
reword
jtotoole f410d28
Revert "remove a bunch of tests"
jtotoole 7208faa
correct failed test + add docs
jtotoole 93913a3
doc - remove tmate
jtotoole 3a9fa4c
Merge branch 'master' into jot-print-test-fails
pypt b1b8cf8
fix munin-node build
jtotoole File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's in
/home/runner/runners/*/_diag/pages/*.log
, i.e. how are you finding those errors? Do you perhaps have a sample log file from that directory that we could look at (without various private credentials that might be in this log)?Grepping (awking?) out failures from a log file is a bit wonky because any test might print a string
FAILURES
at any point for a legitimate reason and still succeed; plus, tests don't have to fail withstatus 1
specifically as they can have any non-zero exit status.