This repository has been archived by the owner on Dec 14, 2023. It is now read-only.
Move to docker hub from gcr #797
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No, why pass those credentials? One is supposed to "docker login" using their own Docker Hub user on their own laptop to be able to push something. If someone quits Media Cloud, we would then have to change those shared credentials on all developer computers instead of simply removing a specific user from Docker Hub organisation. |
|
Cool that was my assumption, just wanted to make sure. The only test fails here are related to Crimson Hexagon, so I think this is good to go assuming it right solid to you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: https://github.com/mediacloud/systems/pull/229
Original issue: #794
@pypt Do you think we need to pass the new Docker Hub credentials as args in the dev scripts, along the lines of what was reversed in this PR (e.g. here)? Even without such arguments added to those dev scripts, the images can be built and pushed correctly at present (new Docker Hub repos here).